hack/ci: fix the CI failure summary for non-int suites - #29482
Open
rjgoyln wants to merge 1 commit into
Open
Conversation
rjgoyln
force-pushed
the
fix/ci-log-summary-parser
branch
from
August 12, 2026 18:03
08a26cd to
3f748ed
Compare
rjgoyln
marked this pull request as ready for review
August 12, 2026 18:20
Honny1
approved these changes
Aug 14, 2026
Honny1
left a comment
Contributor
There was a problem hiding this comment.
Just a nonblocking comment. Also, this PR will need to be rebased on upstream. Otherwise, LGTM.
The step summary posted when a CI job fails comes out empty for the bindings suite. github_log_summary.py picks between the ginkgo and bats parsers by looking for "int-" in the file name, but int is not the only ginkgo suite - bindings runs ginkgo as well, so its log is handed to the bats parser and nothing matches. logformatter decides the layout from the log contents, so do the same here. Three more things the script got wrong along the way, all of them kept out of sight by the "|| true" on the workflow step. The workflow passes it a glob but only argv[1] was ever read, so any further log was dropped without a word. A job that produces no html log at all leaves that glob unexpanded, which ended in a traceback. And logformatter reads its input through ':utf8', which validates nothing, so a test that wrote raw bytes leaves behind a log that the summary could not even decode. Signed-off-by: rjgoyln <pt40419@gmail.com>
rjgoyln
force-pushed
the
fix/ci-log-summary-parser
branch
from
August 14, 2026 14:21
3f748ed to
1dd4211
Compare
Contributor
|
PTAL @podman-container-tools/podman-maintainers @podman-container-tools/podman-reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The step summary for failed CI jobs is empty when the failing suite is
bindings.github_log_summary.pyselects the Ginkgo or Bats parser from the log filename, treating onlyint-logs as Ginkgo. Sincebindingsalso uses Ginkgo, its log is parsed as Bats and produces no output. The parser now follows the log contents, matching howlogformatteridentifies the layout.The same entry point has three related issues, all hidden by the workflow step's
|| true: onlyargv[1]was processed even though the workflow passes a glob; a missing HTML log left the glob unexpanded and caused a traceback; and logs containing invalid UTF-8 could not be decoded by the summary script.Tests
Added
hack/ci/github_log_summary_test.pyand included it invalidate-sourcealongsideci_yaml_test.py. Seven of the ten cases fail against the current implementation, covering the new behavior and preserving the class names emitted bylogformatter.Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?