Skip to content

hack/ci: fix the CI failure summary for non-int suites - #29482

Open
rjgoyln wants to merge 1 commit into
podman-container-tools:mainfrom
rjgoyln:fix/ci-log-summary-parser
Open

hack/ci: fix the CI failure summary for non-int suites#29482
rjgoyln wants to merge 1 commit into
podman-container-tools:mainfrom
rjgoyln:fix/ci-log-summary-parser

Conversation

@rjgoyln

@rjgoyln rjgoyln commented Aug 12, 2026

Copy link
Copy Markdown

Summary

The step summary for failed CI jobs is empty when the failing suite is bindings. github_log_summary.py selects the Ginkgo or Bats parser from the log filename, treating only int- logs as Ginkgo. Since bindings also uses Ginkgo, its log is parsed as Bats and produces no output. The parser now follows the log contents, matching how logformatter identifies the layout.

The same entry point has three related issues, all hidden by the workflow step's || true: only argv[1] was processed even though the workflow passes a glob; a missing HTML log left the glob unexpanded and caused a traceback; and logs containing invalid UTF-8 could not be decoded by the summary script.

Tests

Added hack/ci/github_log_summary_test.py and included it in validate-source alongside ci_yaml_test.py. Seven of the ten cases fail against the current implementation, covering the new behavior and preserving the class names emitted by logformatter.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • I have read and understood our contributing guidelines and will not have more than two open PRs as a new contributor.
  • PR description, commit message, and GitHub comments are human-written, per LLM Policy
  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@github-actions github-actions Bot added the CI label Aug 12, 2026
@rjgoyln
rjgoyln force-pushed the fix/ci-log-summary-parser branch from 08a26cd to 3f748ed Compare August 12, 2026 18:03
@rjgoyln
rjgoyln marked this pull request as ready for review August 12, 2026 18:20

@Honny1 Honny1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nonblocking comment. Also, this PR will need to be rebased on upstream. Otherwise, LGTM.

Comment thread Makefile Outdated
The step summary posted when a CI job fails comes out empty for the
bindings suite. github_log_summary.py picks between the ginkgo and bats
parsers by looking for "int-" in the file name, but int is not the only
ginkgo suite - bindings runs ginkgo as well, so its log is handed to the
bats parser and nothing matches. logformatter decides the layout from
the log contents, so do the same here.

Three more things the script got wrong along the way, all of them kept
out of sight by the "|| true" on the workflow step. The workflow passes
it a glob but only argv[1] was ever read, so any further log was dropped
without a word. A job that produces no html log at all leaves that glob
unexpanded, which ended in a traceback. And logformatter reads its input
through ':utf8', which validates nothing, so a test that wrote raw bytes
leaves behind a log that the summary could not even decode.

Signed-off-by: rjgoyln <pt40419@gmail.com>
@rjgoyln
rjgoyln force-pushed the fix/ci-log-summary-parser branch from 3f748ed to 1dd4211 Compare August 14, 2026 14:21
@Honny1

Honny1 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

PTAL @podman-container-tools/podman-maintainers @podman-container-tools/podman-reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants